Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues in the transfers form by updating the validation schema. The changes address both the Zod validation code format and the return value type conversion.
- Updated Zod issue code from enum to string format
- Changed return value from BigInt conversion to regular number
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| return z.NEVER; | ||
| } | ||
| return BigInt(num * 10 ** (decimals || 0)); | ||
| return num * 10 ** (decimals || 0); |
There was a problem hiding this comment.
Removing BigInt conversion may cause precision loss for large token amounts. Token amounts typically require BigInt to handle values beyond JavaScript's safe integer range (2^53 - 1).
Suggested change
| return num * 10 ** (decimals || 0); | |
| // Convert the value to base units using BigInt to avoid precision loss | |
| try { | |
| // Use string arithmetic to avoid floating point errors | |
| const decimalsCount = decimals || 0; | |
| // Split into integer and fractional parts | |
| const [integerPart, fractionalPart = ""] = val.split("."); | |
| let baseUnits = BigInt(integerPart) * BigInt(10) ** BigInt(decimalsCount); | |
| if (fractionalPart.length > 0) { | |
| // Only take up to 'decimalsCount' digits from the fractional part | |
| const frac = fractionalPart.padEnd(decimalsCount, "0").slice(0, decimalsCount); | |
| baseUnits += BigInt(frac); | |
| } | |
| return baseUnits; | |
| } catch (e) { | |
| ctx.addIssue({ | |
| message: "Invalid value", | |
| code: "custom" | |
| }); | |
| return z.NEVER; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.