Skip to content

Commit 7e17454

Browse files
Cafe137github-actions[bot]
Cafe137
and
github-actions[bot]
authored
fix: replace uint8array body (#1142)
* fix: replace uint8array body * test: update test coverage --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent dce10e8 commit 7e17454

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

‎src/utils/http.ts‎

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,7 @@ export async function http<T>(options: BeeRequestOptions, config: AxiosRequestCo
5252
throwIfAborted(options.signal, config)
5353
}
5454

55-
if (requestConfig.data && typeof Buffer !== 'undefined' && Buffer.isBuffer(requestConfig.data)) {
56-
requestConfig.data = requestConfig.data.buffer.slice(
57-
requestConfig.data.byteOffset,
58-
requestConfig.data.byteOffset + requestConfig.data.byteLength,
59-
)
60-
}
55+
maybeReplaceBodyBuffers(requestConfig)
6156

6257
if (requestConfig.params) {
6358
const keys = Object.keys(requestConfig.params)
@@ -123,3 +118,13 @@ function maybeRunOnRequestHook(options: BeeRequestOptions, requestConfig: AxiosR
123118
})
124119
}
125120
}
121+
122+
function maybeReplaceBodyBuffers(config: AxiosRequestConfig): void {
123+
if (config.data && config.data instanceof Uint8Array) {
124+
config.data = config.data.buffer.slice(config.data.byteOffset, config.data.byteOffset + config.data.byteLength)
125+
}
126+
127+
if (config.data && typeof Buffer !== 'undefined' && Buffer.isBuffer(config.data)) {
128+
config.data = config.data.buffer.slice(config.data.byteOffset, config.data.byteOffset + config.data.byteLength)
129+
}
130+
}

‎test/coverage/coverage-summary.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
{"total": {"lines":{"total":2512,"covered":2051,"skipped":0,"pct":81.64},"statements":{"total":2557,"covered":2092,"skipped":0,"pct":81.81},"functions":{"total":613,"covered":488,"skipped":0,"pct":79.6},"branches":{"total":816,"covered":554,"skipped":0,"pct":67.89},"branchesTrue":{"total":0,"covered":0,"skipped":0,"pct":100}}
1+
{"total": {"lines":{"total":2515,"covered":2054,"skipped":0,"pct":81.66},"statements":{"total":2560,"covered":2095,"skipped":0,"pct":81.83},"functions":{"total":614,"covered":489,"skipped":0,"pct":79.64},"branches":{"total":820,"covered":557,"skipped":0,"pct":67.92},"branchesTrue":{"total":0,"covered":0,"skipped":0,"pct":100}}
22
,"/home/runner/work/bee-js/bee-js/src/bee-dev.ts": {"lines":{"total":14,"covered":5,"skipped":0,"pct":35.71},"functions":{"total":2,"covered":0,"skipped":0,"pct":0},"statements":{"total":14,"covered":5,"skipped":0,"pct":35.71},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
3-
,"/home/runner/work/bee-js/bee-js/src/bee.ts": {"lines":{"total":453,"covered":377,"skipped":0,"pct":83.22},"functions":{"total":132,"covered":108,"skipped":0,"pct":81.81},"statements":{"total":456,"covered":380,"skipped":0,"pct":83.33},"branches":{"total":170,"covered":113,"skipped":0,"pct":66.47}}
3+
,"/home/runner/work/bee-js/bee-js/src/bee.ts": {"lines":{"total":453,"covered":377,"skipped":0,"pct":83.22},"functions":{"total":132,"covered":108,"skipped":0,"pct":81.81},"statements":{"total":456,"covered":380,"skipped":0,"pct":83.33},"branches":{"total":170,"covered":112,"skipped":0,"pct":65.88}}
44
,"/home/runner/work/bee-js/bee-js/src/index.ts": {"lines":{"total":16,"covered":16,"skipped":0,"pct":100},"functions":{"total":10,"covered":7,"skipped":0,"pct":70},"statements":{"total":25,"covered":25,"skipped":0,"pct":100},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
55
,"/home/runner/work/bee-js/bee-js/src/chunk/bmt.ts": {"lines":{"total":16,"covered":15,"skipped":0,"pct":93.75},"functions":{"total":3,"covered":3,"skipped":0,"pct":100},"statements":{"total":17,"covered":16,"skipped":0,"pct":94.11},"branches":{"total":2,"covered":1,"skipped":0,"pct":50}}
66
,"/home/runner/work/bee-js/bee-js/src/chunk/cac.ts": {"lines":{"total":21,"covered":20,"skipped":0,"pct":95.23},"functions":{"total":3,"covered":3,"skipped":0,"pct":100},"statements":{"total":21,"covered":20,"skipped":0,"pct":95.23},"branches":{"total":10,"covered":8,"skipped":0,"pct":80}}
@@ -51,7 +51,7 @@
5151
,"/home/runner/work/bee-js/bee-js/src/utils/expose.ts": {"lines":{"total":16,"covered":16,"skipped":0,"pct":100},"functions":{"total":18,"covered":14,"skipped":0,"pct":77.77},"statements":{"total":23,"covered":23,"skipped":0,"pct":100},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
5252
,"/home/runner/work/bee-js/bee-js/src/utils/file.ts": {"lines":{"total":12,"covered":8,"skipped":0,"pct":66.66},"functions":{"total":4,"covered":2,"skipped":0,"pct":50},"statements":{"total":13,"covered":8,"skipped":0,"pct":61.53},"branches":{"total":10,"covered":7,"skipped":0,"pct":70}}
5353
,"/home/runner/work/bee-js/bee-js/src/utils/headers.ts": {"lines":{"total":71,"covered":62,"skipped":0,"pct":87.32},"functions":{"total":5,"covered":5,"skipped":0,"pct":100},"statements":{"total":71,"covered":62,"skipped":0,"pct":87.32},"branches":{"total":64,"covered":54,"skipped":0,"pct":84.37}}
54-
,"/home/runner/work/bee-js/bee-js/src/utils/http.ts": {"lines":{"total":46,"covered":41,"skipped":0,"pct":89.13},"functions":{"total":3,"covered":3,"skipped":0,"pct":100},"statements":{"total":46,"covered":41,"skipped":0,"pct":89.13},"branches":{"total":37,"covered":27,"skipped":0,"pct":72.97}}
54+
,"/home/runner/work/bee-js/bee-js/src/utils/http.ts": {"lines":{"total":49,"covered":44,"skipped":0,"pct":89.79},"functions":{"total":4,"covered":4,"skipped":0,"pct":100},"statements":{"total":49,"covered":44,"skipped":0,"pct":89.79},"branches":{"total":41,"covered":31,"skipped":0,"pct":75.6}}
5555
,"/home/runner/work/bee-js/bee-js/src/utils/mime.ts": {"lines":{"total":1,"covered":1,"skipped":0,"pct":100},"functions":{"total":0,"covered":0,"skipped":0,"pct":100},"statements":{"total":1,"covered":1,"skipped":0,"pct":100},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
5656
,"/home/runner/work/bee-js/bee-js/src/utils/pss.ts": {"lines":{"total":5,"covered":5,"skipped":0,"pct":100},"functions":{"total":1,"covered":1,"skipped":0,"pct":100},"statements":{"total":5,"covered":5,"skipped":0,"pct":100},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
5757
,"/home/runner/work/bee-js/bee-js/src/utils/redundancy.ts": {"lines":{"total":44,"covered":32,"skipped":0,"pct":72.72},"functions":{"total":4,"covered":4,"skipped":0,"pct":100},"statements":{"total":45,"covered":33,"skipped":0,"pct":73.33},"branches":{"total":29,"covered":14,"skipped":0,"pct":48.27}}

0 commit comments

Comments
 (0)