Skip to content

Fix tests for EIP-3860#1125

Merged
winsvega merged 4 commits intoethereum:developfrom
ipsilon:eip-3860-fix
Jan 6, 2023
Merged

Fix tests for EIP-3860#1125
winsvega merged 4 commits intoethereum:developfrom
ipsilon:eip-3860-fix

Conversation

@gumb0
Copy link
Member

@gumb0 gumb0 commented Dec 27, 2022

Implementation used ethereum/go-ethereum@805e691

Required error definition in retesteth

      "TR_InitCodeLimitExceeded" : "max initcode size exceeded",

@winsvega
Copy link

winsvega commented Jan 2, 2023

@gumb0 ready?

@chfast
Copy link
Member

chfast commented Jan 3, 2023

Required error definition in retesteth

      "TR_InitCodeLimitExceeded" : "max initcode size exceeded",

Still needed?

@gumb0
Copy link
Member Author

gumb0 commented Jan 3, 2023

Required error definition in retesteth

      "TR_InitCodeLimitExceeded" : "max initcode size exceeded",

Still needed?

I think so, it is used in creationTxInitCodeSizeLimitFiller.yml

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from evmone side.

yperbasis added a commit to erigontech/erigon that referenced this pull request Jan 4, 2023
@winsvega winsvega merged commit 8f90796 into ethereum:develop Jan 6, 2023
@gumb0 gumb0 deleted the eip-3860-fix branch January 6, 2023 14:50
yperbasis added a commit to erigontech/erigon that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants