Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Validate checksum for eth1_withdrawal_address#338

Merged
hwwhww merged 2 commits intoethereum:devfrom
shicks:validate
Mar 13, 2023
Merged

Validate checksum for eth1_withdrawal_address#338
hwwhww merged 2 commits intoethereum:devfrom
shicks:validate

Conversation

@shicks
Copy link
Copy Markdown
Contributor

@shicks shicks commented Mar 12, 2023

If the given address is checksummed, the checksum will be validated and will error out eagerly if it's incorrect.

@hwwhww hwwhww changed the base branch from master to dev March 13, 2023 19:35
shicks and others added 2 commits March 14, 2023 03:44
If the given address is checksummed, the checksum will be validated and will error out eagerly if it's incorrect.
Copy link
Copy Markdown
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shicks 👋

Thank you for making this PR!!
The validation was added in #313 so I fixed the conflicts. The tests are good, I just changed the scripts since it now asks the user to re-type and confirms their eth1_withdrawal_address input.

@hwwhww hwwhww merged commit 395f813 into ethereum:dev Mar 13, 2023
sangheraio pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
Validate checksum for eth1_withdrawal_address
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants