This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Conversation
hwwhww
approved these changes
Mar 24, 2022
Contributor
hwwhww
left a comment
hwwhww
left a comment
There was a problem hiding this comment.
LGTM!
really appreciate making the hash updates 🙏
Collaborator
Author
|
Tested the binaries on both Win10 and Win11 machines with the latest security patches and this seems to have solved Windows' misplaced concerns about it being a trojan... Thanks to @SomerEsat for the bug report & helping with the testing. I updated the branch protection rules for dev for the new |
Merged
Merged
sangheraio
pushed a commit
to earthwallet/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
Version bumps packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Minimum Python version
I wanted to keep support for Python 3.7 as it will receive security patches until 2023-06, but officially it stopped receiving support in 2020-06 and so many packages needed >=3.8 in order to be updated. As such, I migrated minimum version requirements to Python 3.8.
CLI Binaries Python Version
We used to build the binaries with 3.7 to ensure maximum support, but I discovered this is not actually the case. As PyInstaller bundles the Python interpreter with the package, we do not need to use an older version of python. As such, I upgraded the builds to run off of 3.10.
Testing Python Versions
In accordance with the above changes, CI testing now happens for Python 3.8 & 3.10