Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Bump versions to support M1 binary builds + fix load_text for binaries#233

Merged
hwwhww merged 4 commits intodevfrom
m1-binaries
Jan 31, 2022
Merged

Bump versions to support M1 binary builds + fix load_text for binaries#233
hwwhww merged 4 commits intodevfrom
m1-binaries

Conversation

@CarlBeek
Copy link
Copy Markdown
Collaborator

  • Bumps versions to support M1 Building (locally)
  • Adds explanation to README.md on how to build binaries on M1 with pyenv

@CarlBeek CarlBeek requested a review from hwwhww January 27, 2022 20:31
@hwwhww
Copy link
Copy Markdown
Contributor

hwwhww commented Jan 31, 2022

@CarlBeek I fixed the binary file tests!
It seems somehow inspect.stack()[1].filename gets .pyc file instead of .py.

Copy link
Copy Markdown
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hwwhww hwwhww merged commit 32745ba into dev Jan 31, 2022
@hwwhww hwwhww deleted the m1-binaries branch January 31, 2022 23:03
@hwwhww hwwhww changed the title Bump versions to support M1 binary builds Bump versions to support M1 binary builds + fix load_text for binaries Jan 31, 2022
sangheraio pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
Bump versions to support M1 binary builds
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants