This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Added clarification on number of validators prompt#204
Closed
colfax23 wants to merge 1 commit intoethereum:devfrom
Closed
Added clarification on number of validators prompt#204colfax23 wants to merge 1 commit intoethereum:devfrom
colfax23 wants to merge 1 commit intoethereum:devfrom
Conversation
|
Yes! Was confused by that wording too :) |
Contributor
Author
Collaborator
|
Thanks for opening this PR, @colfax23! 🙏 I created a new PR which solves this same issue, but rebased off of This change will then be merged into the releases from there. |
Contributor
Author
|
Awesome! Of course :) Thanks for taking a look and including. |
Collaborator
|
closing as this has been included in the new internationalised versions of the launchpad |
|
Please confirm me as a validator
…On Wed, Feb 2, 2022, 16:49 Carl Beekhuizen, ***@***.***> wrote:
Closed #204 <#204>.
—
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKSH745HGA46LH6BLOV3VJ3UZGRINANCNFSM46DF4SVQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there - thanks for all the work on this tool, it's great. While testing it out recently, I noticed that the prompt for the number of keys to generate is unclear (mostly when running with an existing mnemonic). It currently reads, for both new and existing mnemonics, as:
"Please choose how many validators you wish to run"
This makes sense for creating from a new mnemonic, but when creating from an existing mnemonic it is unclear if that prompt is asking you for the total validators you'd like to run (including those you already have keys for) or just the number of new ones. After testing, it is the latter - you are supposed to specify the number of new validators you'd like to generate keys for.
This PR simply changes the above from "validators" to "new validators" which I feel makes it more clear. I understand the same prompt is use for both new and existing flows, and I think will both benefit from the clarity.
Thanks in advance for taking a look!