This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Conversation
hwwhww
commented
Mar 25, 2021
| def validate_eth1_withdrawal_address(cts: click.Context, param: Any, address: str) -> HexAddress: | ||
| if address is None: | ||
| return None | ||
| if not is_hex_address(address): |
Contributor
Author
There was a problem hiding this comment.
Note: the prefix 0x is optional here.
Contributor
Author
|
/cc @djrtwo |
CarlBeek
suggested changes
Mar 30, 2021
Collaborator
CarlBeek
left a comment
CarlBeek
left a comment
There was a problem hiding this comment.
I like that this is being added. 👍
One issue is that by adding this functionality to generate_keys it is automagically added to both the new-mnemonic and existing-mnemonic commands. The latter of which doesn't have tests and isn't mentioned in the README.
CarlBeek
approved these changes
Mar 30, 2021
This was referenced Mar 30, 2021
sangheraio
pushed a commit
to earthwallet/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
Add Eth1 address withdrawal support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #188, support ethereum/consensus-specs#2149
--eth1_withdrawal_addressargument: If this field is set and valid, the given Eth1 address will be used to create the withdrawal credentials. Otherwise, it will generate withdrawal credentials with the mnemonic-derived withdrawal public key.validate_deposit: add public key and withdrawal credentials validations.