This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Conversation
|
hwwhww
approved these changes
Jan 26, 2021
Contributor
hwwhww
left a comment
hwwhww
left a comment
There was a problem hiding this comment.
The PR looks good.
I guess some users may see new permission denied errors per their environment configurations. What do you think about adding a note about the 440 permission to the README.md?
Collaborator
Author
|
Definitly worth explaining in the README.md, thanks for the recommendation. |
Merged
sangheraio
pushed a commit
to earthwallet/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
chmod keystores and deposit_data.json to `440`
sangheraio
pushed a commit
to earthwallet/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
## Release v1.1.1: * Ensure keystore permissions are 440 ethereum#176 * Adds Prater testnet support ethereum#189 * Removes support for old testnets (Witti, Altona, Medalla, Spadina, Zinken) ethereum#189
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File permissions seem different between users and are usually globally readable. This PR address this by
chmoding the keystores anddeposit_data.jsonto440owner and group read only.