Skip to content
This repository was archived by the owner on Sep 5, 2020. It is now read-only.

[travis] revamp multi-platform build#1453

Closed
luclu wants to merge 55 commits intodevelopfrom
luclu_travis
Closed

[travis] revamp multi-platform build#1453
luclu wants to merge 55 commits intodevelopfrom
luclu_travis

Conversation

@luclu
Copy link
Copy Markdown
Contributor

@luclu luclu commented Nov 23, 2016 •
edited by evertonfraga
Loading

Needs rebase on Taylor's merged PR

fixes #1182

Currently splits the builds in (1: sudo trusty) linux + win and (2: osx) mac.

Outstanding TODO:

Selected platform: [ 'mac' ]
[14:01:05] Using gulpfile ~/build/ethereum/mist/gulpfile.js
[14:01:05] Starting 'mist'...
[14:01:05] Starting 'set-variables-mist'...
[14:01:05] Finished 'set-variables-mist' after 140 μs
[14:01:05] Starting 'download-signatures'...
[14:01:05] Starting 'clean:dist'...
[14:01:05] Finished 'clean:dist' after 28 ms
[14:01:05] Starting 'copy-app-source-files'...
[14:01:05] Starting 'copy-node-folder-files'...
[14:01:06] Finished 'copy-app-source-files' after 1.62 s
[14:01:06] Starting 'copy-app-folder-files'...
[14:03:35] Finished 'copy-app-folder-files' after 2.47 min
[14:03:35] Starting 'copy-build-folder-files'...
[14:03:35] 'download-signatures' errored after 2.5 min
[14:03:35] ParseError
    at stream.catch.then.data (/Users/travis/build/ethereum/mist/node_modules/got/index.js:114:14)
    at process._tickCallback (internal/process/next_tick.js:103:7)
[14:03:35] 'mist' errored after 2.5 min
[14:03:35] ParseError in plugin 'run-sequence(download-signatures)'
Message:
    Unexpected end of JSON input in "https://www.4byte.directory/api/v1/signatures/?page_size=20000&ordering=created_at": 
{"count":3337,"next":null,"previous":null,"results":[{"id":112,"created_at":"...
Details:
    host: www.4byte.directory
    hostname: www.4byte.directory
    method: GET
    path: /api/v1/signatures/?page_size=20000&ordering=created_at
    statusCode: 200
    statusMessage: OK
Stack:
ParseError
    at stream.catch.then.data (/Users/travis/build/ethereum/mist/node_modules/got/index.js:114:14)
    at process._tickCallback (internal/process/next_tick.js:103:7)
[14:03:35] Finished 'copy-build-folder-files' after 334 ms
[14:03:35] Finished 'copy-node-folder-files' after 2.5 min
/Users/travis/build.sh: line 151:  3660 Terminated: 15          travis_jigger $! $timeout $cmd
  • upload to github releases if tag available
  • promisify download-signatures as the command does not finish in time for the copy stage when using travis, simpler alternative: use sync instead of async but will increase build-time by 3-7s
  • no continuous output of travis wait-wrapped command travis_wait discards wrapped command output travis-ci/travis-ci#5716

@mention-bot
Copy link
Copy Markdown

mention-bot commented Nov 23, 2016

@luclu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hiddentao to be a potential reviewer.

@luclu luclu mentioned this pull request Nov 29, 2016
Closed
10 tasks
Luca Zeug added 4 commits December 6, 2016 18:37
globallize 'gulp' install
0935226
remove caches
ada9831 
- node_modules as yarn has already a great caching
- .cache as this can cause problems with missing global npm modules and changed .travis config
- .electron as this is already more efficently cached by travis cluster
[gulpfile] copy NSIS executable to releases dir
6df57d1
globalize npm 'yarn' install
fe46c72 
- was missing on osx
- travis has its internal version of yarn on linux
@tgerring tgerring mentioned this pull request Dec 6, 2016
Merged
@luclu
Copy link
Copy Markdown
Contributor Author

luclu commented Mar 27, 2017

superseeded

@luclu luclu closed this Mar 27, 2017
@luclu luclu deleted the luclu_travis branch March 27, 2017 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Type: Canonical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

switch travis-ci build environment to macosx

4 participants

@luclu @mention-bot @evertonfraga @tgerring