Skip to content

rpc: be less restrictive on the request id#2282

Closed
bas-vk wants to merge 1 commit intoethereum:developfrom
bas-vk:rpc-id
Closed

rpc: be less restrictive on the request id#2282
bas-vk wants to merge 1 commit intoethereum:developfrom
bas-vk:rpc-id

Conversation

@bas-vk
Copy link
Copy Markdown
Member

@bas-vk bas-vk commented Mar 2, 2016

The new RPC implementation only allows integers as request id which is a bit too restricted. This PR complies with the JSON-RPC standard and allows integers, strings and null to be used as request id's.

Closes: #2270

@robotally
Copy link
Copy Markdown

robotally commented Mar 2, 2016

Vote Count Reviewers
👍 0
👎 0

Updated: Fri Mar 18 09:29:55 UTC 2016

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 2, 2016

Current coverage is 50.93%

Merging #2282 into develop will increase coverage by +0.05% as of 06fea4a

Powered by Codecov. Updated on successful CI builds.

@fjl
Copy link
Copy Markdown
Contributor

fjl commented Mar 2, 2016

It might be easier to use json.RawMessage, see http://play.golang.org/p/9_SuJRYklJ

@bas-vk
Copy link
Copy Markdown
Member Author

bas-vk commented Mar 3, 2016

That was actually my initial approach but decided not to use it because:

  1. we still need to check if the id follows the specification (number, string, null). That means we have to validate the raw json.RawMessage which is a bit harder than validating an already parsed value.
  2. the custom MarshalJSON method on json.RawMessage only works for receiver types, otherwise it would base64 encode on marshalling. Since the json codec implements the ServerCodec which defines the interface{} type for the request id we need to put type assertions.

@fjl
Copy link
Copy Markdown
Contributor

fjl commented Mar 4, 2016

Example with validation and encoding: http://play.golang.org/p/aT1e3Q5HbO

the custom MarshalJSON method on json.RawMessage only works for receiver types, otherwise it would base64 encode on marshalling.

MarshalJSON for json.RawMessage has pointer receiver. This means that it will only be called if the value is addressable. In the example above, the encoding works because the request is passed to json.Marshal as a pointer (which makes the field addressable).

@fjl fjl added this to the 1.4.0 milestone Mar 14, 2016
@fjl fjl added the regression label Mar 14, 2016
@bas-vk bas-vk closed this Mar 18, 2016
@bas-vk
Copy link
Copy Markdown
Member Author

bas-vk commented Mar 18, 2016

integrated in #2359

@obscuren obscuren modified the milestone: 1.4.0 Apr 13, 2016
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Apr 17, 2024
@buddh0 @galaio
@emailtovamos @zlacfzy @zzzckck
BlobTx: implement EIP-4844 on BSC (ethereum#2279)
38db9bf 
* ci: temp enable blobtx branch ci run;
* Switch ON blobpool & ensure Cancun hardfork can occur (ethereum#2223)
* feat: support blob storage & miscs; (ethereum#2229)
* chainconfig: use cancun fork for BSC;
* feat: fill WithdrawalsHash when BSC enable cancun fork;
* rawdb: support to CRUD blobs;
* freezer: support to freeze block blobs;
* blockchain: add blob cache & blob query helper;
* freezer: refactor addition table logic, add uts;
* blobexpiry: add more extra expiry time, and logs;
* parlia: implement IsDataAvailable function;
* blob: refactor blob transfer logic;
* blob: support config blob extra reserve;
* blockchian: support to import block with blob & blobGasFee; (ethereum#2260)
* blob: implement min&max gas price logic;
* blockchian: support import side chain;
* blobpool: reject the banned address;
* blockchain: add chasing head for DA check;
* params: update blob related config;
* blockchain: opt data available checking performance;
* params: modify blob related params;
* gasprice: support BEP-336 blob gas price calculate;
* blobTx: mining + brodcasting (ethereum#2253)
* blobtx mining pass (ethereum#2282)
* Sidecar fetching changes for 4844 (ethereum#2283)
* ci: temp enable blobtx branch ci run;
* Switch ON blobpool & ensure Cancun hardfork can occur (ethereum#2223)
* feat: support blob storage & miscs; (ethereum#2229)
* chainconfig: use cancun fork for BSC;
feat: fill WithdrawalsHash when BSC enable cancun fork;
* rawdb: support to CRUD blobs;
* freezer: support to freeze block blobs;
* blockchain: add blob cache & blob query helper;
* freezer: refactor addition table logic, add uts;
* blobexpiry: add more extra expiry time, and logs;
* parlia: implement IsDataAvailable function;
* blob: refactor blob transfer logic;
* blob: support config blob extra reserve;
* blockchian: support to import block with blob & blobGasFee; (ethereum#2260)
* blob: implement min&max gas price logic;
* blockchian: support import side chain;
* blobpool: reject the banned address;
* blockchain: add chasing head for DA check;
* params: update blob related config;
* blockchain: opt data available checking performance;
* params: modify blob related params;
* gasprice: support BEP-336 blob gas price calculate;
* fix failed check for WithdrawalsHash (ethereum#2276)
* eth: include sidecars in fitering of body
* core: refactor sidecars name
* eth: sidecars type refactor
* core: remove extra from bad merge
* eth: fix handlenewblock test after merge
* Implement eth_getBlobSidecars && eth_getBlobSidecarByTxHash (ethereum#2286)
* execution: add blob gas fee reward to system;
* syncing: support blob syncing & DA checking;
* naming: rename blobs to sidecars;
* fix the semantics of WithXXX (ethereum#2293)
* config: reduce sidecar cache to 1024 and rename (ethereum#2297)
* fix: Withdrawals turn into empty from nil when BlockBody has Sidecars (ethereum#2301)
* internal/api_test: add test case for eth_getBlobSidecars && eth_getBlobSidecarByTxHash (ethereum#2300)
* consensus/misc: rollback CalcBlobFee (ethereum#2306)
* flags: add new flags to override blobs' params;
* freezer: fix blob ancient save error;
* blobsidecar: add new sidecar struct with metadata; (ethereum#2315)
* core/rawdb: optimize write block with sidecars (ethereum#2318)
* core: more check for validity of sidecars
* mev: add TxIndex for mev bid (ethereum#2325)
* remove useless Config() (ethereum#2326)
* fix WithSidecars (ethereum#2327)
* fix: fix mined block sidecar issue; (ethereum#2328)
* fix WithSidecars (ethereum#2329)

---------
Co-authored-by: GalaIO <[email protected]>
Co-authored-by: buddho <[email protected]>
Co-authored-by: Satyajit Das <[email protected]>
Co-authored-by: Eric <[email protected]>
Co-authored-by: zzzckck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bas-vk @robotally @codecov-io @fjl @obscuren