eth/downloader: match capabilities when querying idle peers#1866
Merged
obscuren merged 1 commit intoethereum:developfrom Oct 2, 2015
karalabe:honor-eth-capabilities
Merged
eth/downloader: match capabilities when querying idle peers#1866obscuren merged 1 commit intoethereum:developfrom karalabe:honor-eth-capabilities
obscuren merged 1 commit intoethereum:developfrom
karalabe:honor-eth-capabilities
Conversation
Updated: Fri Oct 2 10:47:39 UTC 2015 |
Contributor
|
👍 |
1 similar comment
|
👍 |
obscuren
added a commit
that referenced
this pull request
Oct 2, 2015
eth/downloader: match capabilities when querying idle peers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a capability matching issue in the downloader. Although we correctly stored the eth protocol version for each of our peers and correctly selected the sync packages to use depending on the protocol currently being synced with, when retrieving idle peers to assign new tasks to I returned all available peers and forgot to check that they can indeed talk the protocol being synced on. Fixing this simply entailed in separating eth/61 peers from eth/62+ peers. This will still exhibit a similar issue when going up to eth/63, but idle peer retrieval was rewritten in eth/63 so that will be sorted out in a different way.