Skip to content

core: deadlock in chainmanager after posting RemovedTransactionEvent#1865

Merged
obscuren merged 1 commit intoethereum:developfrom
obscuren:deadlock-chainmanager-fix
Oct 2, 2015
Merged

core: deadlock in chainmanager after posting RemovedTransactionEvent#1865
obscuren merged 1 commit intoethereum:developfrom
obscuren:deadlock-chainmanager-fix

Conversation

@obscuren
Copy link
Copy Markdown
Contributor

@obscuren obscuren commented Oct 2, 2015

This PR solves an issue with the chain manager posting a
RemovedTransactionEvent, the tx pool will try to
acquire the chainmanager lock which has previously been locked prior to
posting RemovedTransactionEvent. This results in a deadlock in the
core.

This PR solves an issue with the chain manager posting a
`RemovedTransactionEvent`, the tx pool will try to
acquire the chainmanager lock which has previously been locked prior to
posting `RemovedTransactionEvent`. This results in a deadlock in the
core.
@robotally
Copy link
Copy Markdown

Vote Count Reviewers
👍 1 @fjl
👎 0

Updated: Fri Oct 2 10:23:58 UTC 2015

@fjl
Copy link
Copy Markdown
Contributor

fjl commented Oct 2, 2015

👍

obscuren added a commit that referenced this pull request Oct 2, 2015
core: deadlock in chainmanager after posting RemovedTransactionEvent
@obscuren obscuren merged commit 0d78f96 into ethereum:develop Oct 2, 2015
@obscuren obscuren removed the review label Oct 2, 2015
@obscuren obscuren modified the milestone: 1.3.0 Oct 28, 2015
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Nov 20, 2025
* consensus, internal: don't limit gas cap for system txns

* internal/ethapi: handle nil receiver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants