feat(test): update EIP-8024 refspec and align on latest changes to EIP#2095
Conversation
|
|
jochem-brouwer
left a comment
jochem-brouwer
left a comment
There was a problem hiding this comment.
The comment made on the test applies for all 3. I think you could also collapse these in 1 test, by parametrizing the opcode. Unless the PUSHs per test have a specific purpose (they differ between the tests). So you can test_eip_vector_OPNAME_end_of_code
tests/amsterdam/eip8024_dupn_swapn_exchange/test_eip_vectors.py
Outdated
Show resolved
Hide resolved
fselmo
force-pushed
the
feat/update-eip-8024-to-spec
branch
2 times, most recently
from
81140aa to
d0ce332
Compare
fselmo
force-pushed
the
feat/update-eip-8024-to-spec
branch
from
d0ce332 to
5203380
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-8024 #2095 +/- ##
==========================================================
Coverage ? 86.31%
==========================================================
Files ? 599
Lines ? 39523
Branches ? 3789
==========================================================
Hits ? 34113
Misses ? 4818
Partials ? 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
🗒️ Description
Updates to EIP-8024 since the last refspec hash:
Add test cases for expected end-of-code behavior
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.Cute Animal Picture