feat(spec-specs): (EIP-7778) revert to post refund gas in receipts#2073
Conversation
87e2b2c to
7157947
Compare
|
@nerolation draft implementation of the discussed changes so we have something ready to go once a decision is made |
7157947 to
3813ca6
Compare
3813ca6 to
5879a7d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7778 #2073 +/- ##
===========================================================
- Coverage 86.33% 86.14% -0.20%
===========================================================
Files 538 599 +61
Lines 34557 39475 +4918
Branches 3222 3780 +558
===========================================================
+ Hits 29835 34005 +4170
- Misses 4148 4848 +700
- Partials 574 622 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| """ | ||
| Total gas used in the block up to and including this transaction. | ||
| This is the gas used before refunds, used for block gas accounting. | ||
| This is the gas used after refunds, paid by the user. |
There was a problem hiding this comment.
Just to clarify, this field now contains this:
sum(tx.gas_used_before_refunds for tx in txs[:i]) + txs[i].gas_used_after_refundsThere was a problem hiding this comment.
No. This is going to be
sum(tx.gas_used_after_refunds for tx in txs[:i]))
This is exactly how it was before EIP-7778. So essentially, EIP-7778 does not change the receipts themselves. (except the fact that block gas accounting will no longer be possible using just receipts)
80b55b0
into
ethereum:eips/amsterdam/eip-7778
🗒️ Description
Based on recent discussions the receipt should go back to containing the cumulative gas post refunds (something that the users actually pay)
🔗 Related Issues or PRs
#1874
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture
TBD