Add effectiveGasPrice to eth_getTransactionReceipt#206
Add effectiveGasPrice to eth_getTransactionReceipt#206timbeiko merged 1 commit intoethereum:masterfrom
effectiveGasPrice to eth_getTransactionReceipt#206Conversation
lightclient
force-pushed
the
effective-tip
branch
from
2fc785c to
75e43d8
Compare
lightclient
force-pushed
the
effective-tip
branch
from
75e43d8 to
297e6b7
Compare
|
@timbeiko seems like there hasn't been any push back on this. Do you want to go ahead and merge or should we bring it up briefly in ACD? EDIT: sorry, we should probably discuss on ACD briefly. I see geth uses the |
|
Per ACD, we'll no longer return |
|
It's not fully clear to me what |
|
Also worth noting that digging up a receipt is expensive and if you only want to get the price paid, it's a bit of an overkill to do a database lookup just to get a field that doesn't even need any data whatsoever from the receipt. |
|
I like dropping it. We will likely continue to have more and more new transaction types over time, and not all of them will be able to backfill old properties with reasonable values. If we backfill this time around, people won't write code that is resilient to future transaction changes and they will break in the future rather than today. Given that there are probably (hopefully) more future Ethereum dapp/integration developers than there are today Ethereum dapp/integration developers, I would rather break today users than future users (e.g., train them now, while it is less damaging). |
* Add support for Besu Adds support for Besu using the `t8n-server` command. This command avoids the Java startup penalties and provides similar performance to other clients. Support for "cleanup" tasks is added, in this case to terminate the t8n-server process for Besu. * tests: use chain_id 1 and set protected based on fork * style: clean-up indentation/line-wrapping * fix: use a timeout in post request to fail test in case of t8n error * refactor: don't make shutdown an abstract method * fix: exit with error if the besu t8n tool is ran with xdist -n>0 --------- Co-authored-by: danceratopz <[email protected]>
4 participants
After some discussions, it appears most prefer to add
effectiveGasPriceto the receipt object because it is a computed value, likegasUsed. I've written the method with the idea that legacy transactions will simply returntx.gas_pricefor theeffectiveGasPriceand EIP-1559 txs will actually compute the correct value. This should avoid a scenario where RPC consumers need to branch depending on the tx type to determine the effective cost.cc: @MicahZoltu @tkstanczak @timbeiko @GregTheGreek @fvictorio