Skip to content

fix(test): Increase balance for blob test fails w/ larger blob params#1975

Merged
marioevz merged 1 commit intoethereum:forks/amsterdamfrom
fselmo:fix/blob-test-starting-balance
Jan 7, 2026
Merged

fix(test): Increase balance for blob test fails w/ larger blob params#1975
marioevz merged 1 commit intoethereum:forks/amsterdamfrom
fselmo:fix/blob-test-starting-balance

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Jan 5, 2026

🗒️ Description

  • Fix initial balance for blob tests that need to account for higher balance based on increased blob params. These were failing to fill for Amsterdam, with balance too low, now that we inherit from BPO2.

We will have to rebase eips/amsterdam/eip-7928 again to bring this change back up but this seems most appropriate to be put into forks/amsterdam. To reproduce, try filling with:

uv run fill --clean --fork=Amsterdam -k "test_correct_increasing_blob_gas_costs and parent_excess_blobs_4302"

... from the eips/amsterdam/eip-7928 branch.


Note: These changes will need to be rebased onto eips/amsterdam/eip-7928. I'll do this once this and #1973 are merged.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2026-01-05 at 11 55 24

@fselmo fselmo added this to the amsterdam milestone Jan 5, 2026
@fselmo fselmo added C-bug Category: this is a bug, deviation, or other problem A-test-tests Area: tests for packages/testing labels Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.33%. Comparing base (d618e52) to head (018c684).
⚠️ Report is 11 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #1975   +/-   ##
================================================
  Coverage            86.33%   86.33%           
================================================
  Files                  538      538           
  Lines                34557    34557           
  Branches              3222     3222           
================================================
  Hits                 29835    29835           
  Misses                4148     4148           
  Partials               574      574           
Flag Coverage Δ
unittests 86.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fselmo fselmo requested a review from marioevz January 5, 2026 23:32
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Jan 6, 2026
* chore(tests): fix pre alloc grouping eip4788.

* chore(tests): fix pre alloc grouping eip6110.

* chore(tests): temp skip for type 4 txs for pre alloc grouping eip7934.
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good enough temporary fix.

Eventually I'd like for no test to specify an amount in pre.fund_eoa, but that is a repo-level change.

@marioevz marioevz merged commit 9e56ac9 into ethereum:forks/amsterdam Jan 7, 2026
11 checks passed
@fselmo fselmo deleted the fix/blob-test-starting-balance branch January 7, 2026 14:52
CPerezz pushed a commit to CPerezz/execution-specs that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tests Area: tests for packages/testing C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants