fix(test): Increase balance for blob test fails w/ larger blob params#1975
Merged
marioevz merged 1 commit intoethereum:forks/amsterdamfrom Jan 7, 2026
Merged
Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #1975 +/- ##
================================================
Coverage 86.33% 86.33%
================================================
Files 538 538
Lines 34557 34557
Branches 3222 3222
================================================
Hits 29835 29835
Misses 4148 4148
Partials 574 574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Jan 6, 2026
* chore(tests): fix pre alloc grouping eip4788. * chore(tests): fix pre alloc grouping eip6110. * chore(tests): temp skip for type 4 txs for pre alloc grouping eip7934.
marioevz
approved these changes
Jan 7, 2026
Member
marioevz
left a comment
There was a problem hiding this comment.
LGTM, good enough temporary fix.
Eventually I'd like for no test to specify an amount in pre.fund_eoa, but that is a repo-level change.
CPerezz
pushed a commit
to CPerezz/execution-specs
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
We will have to rebase
eips/amsterdam/eip-7928again to bring this change back up but this seems most appropriate to be put intoforks/amsterdam. To reproduce, try filling with:uv run fill --clean --fork=Amsterdam -k "test_correct_increasing_blob_gas_costs and parent_excess_blobs_4302"... from the
eips/amsterdam/eip-7928branch.Note: These changes will need to be rebased onto
eips/amsterdam/eip-7928. I'll do this once this and #1973 are merged.✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture