feat(test): Turn on filling static tests for bal releases#1973
Merged
marioevz merged 2 commits intoethereum:forks/amsterdamfrom Jan 7, 2026
Merged
feat(test): Turn on filling static tests for bal releases#1973marioevz merged 2 commits intoethereum:forks/amsterdamfrom
marioevz merged 2 commits intoethereum:forks/amsterdamfrom
Conversation
fselmo
added
C-feat
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #1973 +/- ##
================================================
Coverage 86.33% 86.33%
================================================
Files 538 538
Lines 34557 34557
Branches 3222 3222
================================================
Hits 29835 29835
Misses 4148 4148
Partials 574 574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fselmo
force-pushed
the
feat/turn-on-static-tests-bals
branch
from
2233a48 to
e4d7442
Compare
fselmo
force-pushed
the
feat/turn-on-static-tests-bals
branch
from
e4d7442 to
3cca592
Compare
fselmo
force-pushed
the
feat/turn-on-static-tests-bals
branch
from
7e58377 to
4531953
Compare
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Jan 6, 2026
… valid t8n on certain systems (ethereum#1973) * fixes issue where nethtest would not be recognized/found on certain systems depending on how it was compiled
fselmo
changed the base branch from
eips/amsterdam/eip-7928
to
forks/amsterdam
fselmo
force-pushed
the
feat/turn-on-static-tests-bals
branch
from
4531953 to
04fadfd
Compare
5 tasks
marioevz
approved these changes
Jan 7, 2026
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM, makes sense to disable BPO3/4/5 until we have more clarity or we know they are going to happen after Amsterdam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
balrelease for Amsterdam.Amsterdamfork now inherits fromBPO2fork and we fill with BPO2 params. Clients need to turn this on in order to pass blob-related tests.Unrelated
Fix initial balance for blob tests that need to account for higher balance based on increased blob params. These were failing to fill for Amsterdam as well now that we inherit from BPO2.[this change should be inforks/amsterdaminstead, PR created here. With these two PRs together, all tests, including static tests, fill for Amsterdam].Note: These changes will need to be rebased onto
eips/amsterdam/eip-7928. I'll do this once this and #1975 are merged.✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture