eip7928: add SELFDESTRUCT OOG BAL test#1846
Merged
fselmo merged 3 commits intoethereum:eips/amsterdam/eip-7928from Dec 5, 2025
Merged
eip7928: add SELFDESTRUCT OOG BAL test#1846fselmo merged 3 commits intoethereum:eips/amsterdam/eip-7928from
fselmo merged 3 commits intoethereum:eips/amsterdam/eip-7928from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #1846 +/- ##
==========================================================
Coverage ? 82.46%
==========================================================
Files ? 797
Lines ? 47987
Branches ? 4341
==========================================================
Hits ? 39574
Misses ? 7927
Partials ? 486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mirgee
pushed a commit
to mirgee/execution-specs
that referenced
this pull request
Dec 5, 2025
fselmo
approved these changes
Dec 5, 2025
Contributor
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
lgtm! I added a change to the spec (was wrong, need to check gas before account access) and refactored the test to parametrize around the gas boundary. I also moved these self_destruct tests into a the appropriate file within test_block_access_lists_opcodes.py.
@qu0b lmk if these changes look good to you and I'll merge.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this issue when running a kurtosis network. This test currently fails against Besu but other clients tested (nethermind, reth) pass this test.