refactor(bal): Align BAL state_changes with the specs Env hierarchy#1836
Closed
gurukamath wants to merge 4 commits intoethereum:eips/amsterdam/eip-7928from
Closed
refactor(bal): Align BAL state_changes with the specs Env hierarchy#1836gurukamath wants to merge 4 commits intoethereum:eips/amsterdam/eip-7928from
gurukamath wants to merge 4 commits intoethereum:eips/amsterdam/eip-7928from
Conversation
gurukamath
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #1836 +/- ##
========================================================
Coverage 82.46% 82.47%
========================================================
Files 797 797
Lines 47987 47984 -3
Branches 4341 4338 -3
========================================================
+ Hits 39574 39576 +2
+ Misses 7927 7922 -5
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
Contributor
|
@gurukamath #1841 is the larger refactor we talked about. We will review this tomorrow on the call but putting it here for visibility. |
Contributor
Author
|
Closing this since #1841 handles the changes proposed here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR re-factors the BAL code to align it more closely with the
BlockEnvironment->TransactionEnvironment->Messagehierarchy in the specs.🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture