Skip to content

test(eip7928): add cross-block precompile state leak test#1829

Merged
fselmo merged 2 commits intoethereum:eips/amsterdam/eip-7928from
qu0b:qu0b/cross-block-precompile-state-leak
Dec 1, 2025
Merged

test(eip7928): add cross-block precompile state leak test#1829
fselmo merged 2 commits intoethereum:eips/amsterdam/eip-7928from
qu0b:qu0b/cross-block-precompile-state-leak

Conversation

@qu0b
Copy link
Contributor

@qu0b qu0b commented Dec 1, 2025

This test recreates the issue where nethermind would include the 0x03 pre-compile in its block level access list even though the pre-compile is never called in that block, but instead is called in a parent block.

@fselmo fselmo force-pushed the qu0b/cross-block-precompile-state-leak branch from 5b28feb to abef91a Compare December 1, 2025 18:54
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm. Really nice find 🔥

@fselmo fselmo merged commit 67c1983 into ethereum:eips/amsterdam/eip-7928 Dec 1, 2025
9 checks passed
@fselmo fselmo deleted the qu0b/cross-block-precompile-state-leak branch December 1, 2025 23:53
@fselmo fselmo mentioned this pull request Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.46%. Comparing base (e927a67) to head (abef91a).
⚠️ Report is 5 commits behind head on eips/amsterdam/eip-7928.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           eips/amsterdam/eip-7928    #1829   +/-   ##
========================================================
  Coverage                    82.46%   82.46%           
========================================================
  Files                          797      797           
  Lines                        47987    47987           
  Branches                      4341     4341           
========================================================
  Hits                         39574    39574           
  Misses                        7927     7927           
  Partials                       486      486           
Flag Coverage Δ
unittests 82.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SamWilsn pushed a commit that referenced this pull request Dec 9, 2025
* feat(CLZ): add call operation test case for CLZ

* refactor(tests): update for readability

* refactor(tests): update clz call context test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants