feat(tests): Zero gasprice transaction vs account touch#1736
feat(tests): Zero gasprice transaction vs account touch#1736marioevz merged 3 commits intoethereum:forks/osakafrom
Conversation
pdobacz
force-pushed
the
tests/gasprice-touching
branch
from
1969fd3 to
558b9dd
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1736 +/- ##
============================================
Coverage 86.07% 86.07%
============================================
Files 743 743
Lines 44078 44078
Branches 3894 3894
============================================
Hits 37938 37938
Misses 5659 5659
Partials 481 481
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
left a comment
LouisTsai-Csie
left a comment
There was a problem hiding this comment.
I do not really understand the zero gas price behavior between Frontier & Berlin either, but the test structure looks good.
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM, just one comment, thanks!
|
This code in evmone implements basic touching of an account. However, there is one optimization here: we only mark an account as touched if it is empty and exists in the state because it is irrelevant otherwise. |
5 participants
🗒️ Description
I don't fully understand this behavior, but such test covers this piece of code here. I borrowed it from an existing legacy test, but since it seemed to intend to test something entirely different, I ended up stripping it down to what is minimally necessary to fix the missing coverage in a separate test.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.