feat(tests): Add a case for RIPEMD OOGing in early forks#1732
Merged
marioevz merged 2 commits intoethereum:forks/osakafrom Nov 28, 2025
Merged
feat(tests): Add a case for RIPEMD OOGing in early forks#1732marioevz merged 2 commits intoethereum:forks/osakafrom
marioevz merged 2 commits intoethereum:forks/osakafrom
Conversation
pdobacz
force-pushed
the
tests/ripemd-oog
branch
from
696040e to
155a187
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1732 +/- ##
============================================
Coverage 86.08% 86.08%
============================================
Files 743 743
Lines 44076 44076
Branches 3891 3891
============================================
Hits 37941 37941
Misses 5657 5657
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
approved these changes
Nov 4, 2025
Collaborator
LouisTsai-Csie
left a comment
LouisTsai-Csie
left a comment
There was a problem hiding this comment.
Thanks for this!
marioevz
force-pushed
the
tests/ripemd-oog
branch
from
155a187 to
fa6a5c4
Compare
Member
|
Rebased, waiting on CI to merge. |
SamWilsn
pushed a commit
that referenced
this pull request
Dec 9, 2025
* refactor: optimize jumpdest test case * refactor(tests): streamline jumpdest contract creation in worst compute test * Update tests/zkevm/test_worst_compute.py --------- Co-authored-by: Mario Vega <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
There was one aspect (the
0x03quirk) left uncovered in the RIPEMD test, and it turned out to be covered in static tests, so I guess this is a porting PR. I tried to follow the steps, but not 100% sure I did all the (currently) relevant steps.What makes me doubt it's complete is that the test exists (kinda) in
statictests (but only for>=Cancunforks) but also in https://github.com/ethereum/legacytests/blob/master/src/LegacyTests/Constantinople/GeneralStateTestsFiller/stPreCompiledContracts2/CallRipemd160_0Filler.json, I'm not exactly sure which should be put up there in the code. Nevertheless I'm removing the former one from here.🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.@ported_frommarker.