Skip to content

feat(tests): additional tests for header validation rules#1702

Merged
marioevz merged 3 commits intoethereum:forks/osakafrom
pdobacz:tests/header-london
Nov 26, 2025
Merged

feat(tests): additional tests for header validation rules#1702
marioevz merged 3 commits intoethereum:forks/osakafrom
pdobacz:tests/header-london

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Oct 28, 2025 •
edited by spencer-tb
Loading

🗒️ Description

Small test addition for BlockException.INVALID_BASEFEE_PER_GAS being correctly thrown after London. Also some additions to the exception mappers

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@pdobacz pdobacz force-pushed the tests/header-london branch from dd0ecdc to 872321f Compare October 28, 2025 10:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (c3e5260) to head (872321f).
⚠️ Report is 3 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##           forks/osaka    #1702   +/-   ##
============================================
  Coverage        86.07%   86.07%           
============================================
  Files              743      743           
  Lines            44078    44078           
  Branches          3894     3894           
============================================
  Hits             37938    37938           
  Misses            5659     5659           
  Partials           481      481
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

spencer-tb
spencer-tb reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. I am going to assume the extra exception mappings are for the "other" PR?

spencer-tb
spencer-tb approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase too! Approved nonetheless. Lets wait for the "other" PR to be reviewed first and add here afterwards.

@spencer-tb spencer-tb added C-feat Category: an improvement or new feature A-test-tests Area: tests for packages/testing labels Oct 29, 2025
@pdobacz pdobacz force-pushed the tests/header-london branch from 872321f to a8c82e4 Compare October 29, 2025 14:57
@pdobacz pdobacz force-pushed the tests/header-london branch from a8c82e4 to e6e34cf Compare October 29, 2025 15:01
marioevz
marioevz approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

marioevz
marioevz reviewed Nov 26, 2025
View reviewed changes
@marioevz marioevz merged commit bff0f2e into ethereum:forks/osaka Nov 26, 2025
10 of 12 checks passed
@pdobacz pdobacz deleted the tests/header-london branch November 28, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marioevz marioevz marioevz approved these changes

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees

No one assigned

Labels

A-test-tests Area: tests for packages/testing C-feat Category: an improvement or new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pdobacz @codecov-commenter @marioevz @spencer-tb