Skip to content

feat(tests): Deposit contract log with no topics#1693

Merged
spencer-tb merged 2 commits intoethereum:forks/osakafrom
pdobacz:tests/no-topics
Oct 31, 2025
Merged

feat(tests): Deposit contract log with no topics#1693
spencer-tb merged 2 commits intoethereum:forks/osakafrom
pdobacz:tests/no-topics

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Oct 27, 2025

🗒️ Description

Adds a variant of the test_extra_logs test for EIP-6110 modified contract, where the extra event log has no topics at all.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (c3e5260) to head (f5cfc66).
⚠️ Report is 2 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1693   +/-   ##
============================================
  Coverage        86.07%   86.07%           
============================================
  Files              743      743           
  Lines            44078    44078           
  Branches          3894     3894           
============================================
  Hits             37938    37938           
  Misses            5659     5659           
  Partials           481      481           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb added C-feat Category: an improvement or new feature A-test-tests Area: tests for packages/testing labels Oct 29, 2025
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@spencer-tb spencer-tb merged commit 0008dce into ethereum:forks/osaka Oct 31, 2025
3 checks passed
@pdobacz pdobacz deleted the tests/no-topics branch October 31, 2025 19:05
SamWilsn pushed a commit that referenced this pull request Dec 9, 2025
* feat: add zkevm jumpi-intense op

* refactor: update jumpi fallthrough case

* feat(tests): add jumpi intensive contract test

* chore: fix typo

* refactor: optimize jumpi-intensive test case

* refactor(tests): replace hardcoded value with fork specific variable

* Apply suggestions from code review

---------

Co-authored-by: Mario Vega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tests Area: tests for packages/testing C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants