Create eth_call.md by DockBoss · Pull Request #55 · ethereum/execution-apis

DockBoss · 2021-08-12T09:51:08Z

- [ ] Geth - [ ] OpenEthereum - [ ] Nethermind - [ ] Besu - [ ] Erigon

alita-moore · 2021-08-19T03:45:01Z

cc @MicahZoltu @timbeiko @marcindsobczak @gnidan @rekmarks @rakitadragan @vorot93

This is a PR for adding edgecases for the proposed method. In particular, an edgecase is defined as any behavior outside of the OpenRPC specification defined in this repository. This needs approval from all 5 clients before it can be merged. This is one method in a slew soon to come.

MicahZoltu · 2021-08-19T12:11:40Z

src/description/eth_call.md

+
+* **MUST** accept a `from` account that does not exist on-chain and if `from` is not defined it **MUST** be set to `0x0000000000000000000000000000000000000000`
+
+* If the `to` is null or not defined on-chain it **MUST** return an empty hex string


Hmm, is this true? Can contract creations not set returndata?

MicahZoltu · 2021-08-19T12:13:18Z

src/description/eth_call.md

+
+* If the `to` is null or not defined on-chain it **MUST** return an empty hex string
+
+* If `max_fee_per_gas` or `max_priority_fee_per_gas` is set the other must be set manually, otherwise they both **MUST** be set to the `gasPrice` or 0 when `gasPrice` is null


I think the first part of this can be captured by the OpenRPC specification, and thus we shouldn't repeat it here. If it isn't yet captured by the OpenRPC specification then we should fix that (I thought I already did, but maybe not).

It is incorrect to say that these should be "set to the gasPrice". If the user is trying to simulate a legacy transaction, then these should not be set and only gasPrice should be set.

MicahZoltu · 2021-08-19T12:15:01Z

src/description/eth_call.md

@@ -0,0 +1,15 @@
+* **MUST NOT** affect on-chain state 
+
+* **MUST** accept a `from` account that does not exist on-chain and if `from` is not defined it **MUST** be set to `0x0000000000000000000000000000000000000000`


I'm not a huge fan of the "set" terminology here. Consider instead "MUST be interpreted as ..." instead? The receiver isn't "setting" anything, they are reading/interpreting incoming data.

I had to read this sentence several times, it first looked to me like eth-call must accept only from-addresses that do not exist.

MicahZoltu · 2021-08-19T12:17:12Z

src/description/eth_call.md

+
+* If `max_fee_per_gas` or `max_priority_fee_per_gas` is set the other must be set manually, otherwise they both **MUST** be set to the `gasPrice` or 0 when `gasPrice` is null
+
+* **MUST** accept `gas` that is greater than or equal to the minimum price for the current transaction call and less than `2^64 - 1` or `0xffffffffffffffff` 


This can be captured by the specification, so shouldn't be included as an edge case. Also, it is undecided whether this is capped at 2^64-1 or 2^53 (there are two open competing EIPs). Also, "price" is not the right word to use here. I think you mean "cost", but gas cost prior to execution is unknown so that cannot be validated by the client.

MicahZoltu · 2021-08-19T12:18:44Z

src/description/eth_call.md

+
+* **MUST** accept `gas` that is greater than or equal to the minimum price for the current transaction call and less than `2^64 - 1` or `0xffffffffffffffff` 
+
+* **MUST** consider gas to equal 0 if the `gas` parameter is equal to `null` 


I don't think we want this. Instead I think what we want is to specify that either the behavior is undefined, or that the call is executed with XXX gas, or that the call is executed with infinite gas. I don't know what each client does, but I suspect they all do something different here (some I think even may use block gas limit).

Saying that the call should be executed with 0 gas just means "the call should fail with out of gas immediately" which is unlikely the desired behavior.

Yeah, I do not think this is the behaviour. I think the the clients use some specific number for the gas limit in such cases.

You are right, I found for geth it sets the gas to 80000000, I do not know for the other clients.

src/description/eth_call.md

MicahZoltu · 2021-08-19T12:20:14Z

src/description/eth_call.md

+
+* If any fee or `value` is a non-zero value your account balance **MUST** be checked to ensure account has enough funds
+
+* **MUST** accept an optional input parameter `data` to interact with contract methods


This can be expressed in the specification, so no need for an edge case.

Co-authored-by: Micah Zoltu <[email protected]>

alita-moore · 2021-08-23T19:17:53Z

@OhArthits do you represent a client?

lightclient · 2021-08-23T19:21:58Z

Probably just spam.

MicahZoltu · 2021-08-24T12:20:50Z

It is a spam account. Please report to GitHub.

tkstanczak · 2021-08-25T05:42:15Z

src/description/eth_call.md

+
+* **MUST** consider gas to equal 0 if the `gas` parameter is equal to `null` 
+
+* If any non-zero fee or `value` is provided the `from` account balance **MUST** be checked to ensure account has enough funds


what happens if not enough balance on sender account?

The call will not go through. It will give an insufficient funds error.

tkstanczak · 2021-08-25T05:44:02Z

src/description/eth_call.md

@@ -0,0 +1,11 @@
+* **MUST NOT** affect on-chain state 
+
+* **MUST** allow a `from` parameter that does not exist on-chain and if `from` is not defined it **MUST** be interpreted as `0x0000000000000000000000000000000000000000`


What happens if the from account is not an EOA?

Playing around with different from addresses I found that as long as it a 20 byte hex string the behavior is the same.

Create eth_call.md

6811690

- [ ] Geth - [ ] OpenEthereum - [ ] Nethermind - [ ] Besu - [ ] Erigon

MicahZoltu reviewed Aug 19, 2021

View reviewed changes

src/description/eth_call.md Outdated Show resolved Hide resolved

MicahZoltu reviewed Aug 19, 2021

View reviewed changes

alita-moore mentioned this pull request Aug 20, 2021

JSON RPC Endpoints #56

Closed

50 tasks

DockBoss and others added 5 commits August 22, 2021 00:28

Update src/description/eth_call.md

de38b1d

Co-authored-by: Micah Zoltu <[email protected]>

Update eth_call.md

744e204

Update eth_call.md

313b80b

Update eth_call.md

393f714

Update eth_call.md

42f8f48

lightclient added the A-edge-case Area: edge cases label Aug 23, 2021

tkstanczak reviewed Aug 25, 2021

View reviewed changes

alita-moore and others added 3 commits August 25, 2021 00:57

update

dacfb27

Update eth_call.md

a6c87ee

Update eth_call.md

eca45d3

DockBoss closed this Oct 1, 2021


		* MUST accept a `from` account that does not exist on-chain and if `from` is not defined it MUST be set to `0x0000000000000000000000000000000000000000`

		* If the `to` is null or not defined on-chain it MUST return an empty hex string


		* If the `to` is null or not defined on-chain it MUST return an empty hex string

		* If `max_fee_per_gas` or `max_priority_fee_per_gas` is set the other must be set manually, otherwise they both MUST be set to the `gasPrice` or 0 when `gasPrice` is null

		@@ -0,0 +1,15 @@
		* MUST NOT affect on-chain state

		* MUST accept a `from` account that does not exist on-chain and if `from` is not defined it MUST be set to `0x0000000000000000000000000000000000000000`


		* If `max_fee_per_gas` or `max_priority_fee_per_gas` is set the other must be set manually, otherwise they both MUST be set to the `gasPrice` or 0 when `gasPrice` is null

		* MUST accept `gas` that is greater than or equal to the minimum price for the current transaction call and less than `2^64 - 1` or `0xffffffffffffffff`


		* MUST accept `gas` that is greater than or equal to the minimum price for the current transaction call and less than `2^64 - 1` or `0xffffffffffffffff`

		* MUST consider gas to equal 0 if the `gas` parameter is equal to `null`


		* If any fee or `value` is a non-zero value your account balance MUST be checked to ensure account has enough funds

		* MUST accept an optional input parameter `data` to interact with contract methods


		* MUST consider gas to equal 0 if the `gas` parameter is equal to `null`

		* If any non-zero fee or `value` is provided the `from` account balance MUST be checked to ensure account has enough funds

		@@ -0,0 +1,11 @@
		* MUST NOT affect on-chain state

		* MUST allow a `from` parameter that does not exist on-chain and if `from` is not defined it MUST be interpreted as `0x0000000000000000000000000000000000000000`

Conversation

DockBoss commented Aug 12, 2021

Uh oh!

alita-moore commented Aug 19, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alita-moore commented Aug 23, 2021

Uh oh!

lightclient commented Aug 23, 2021

Uh oh!

MicahZoltu commented Aug 24, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DockBoss Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DockBoss Aug 25, 2021 •

edited

Loading