Skip to content

Engine API: validate blob versioned hashes#407

Merged
mkalinin merged 5 commits intomainfrom
mkalinin-patch-8
May 24, 2023
Merged

Engine API: validate blob versioned hashes#407
mkalinin merged 5 commits intomainfrom
mkalinin-patch-8

Conversation

@mkalinin
Copy link
Contributor

Adds blob versioned hashes as a second parameter to engine_newPayloadV3 as a follow up to ethereum/consensus-specs#3345 (comment)

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here 👍

@mkalinin mkalinin marked this pull request as ready for review May 17, 2023 11:55
@mkalinin
Copy link
Contributor Author

More detailed steps to validate blob versioned hashes are added, with the requirement to run this check instantly disregarding the sync process, i.e. in the same way as block hash is validated today.

This PR adds a second parameter to the newPayloadV3. An alternative is to add new ExecutionPayloadRequestV1 container and pass a payload and an expected array of blob hashes inside of this object. I would like to double check that client devs are fine with adding a second parameter vs adding a new container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants