Merged
Conversation
djrtwo
reviewed
Jan 24, 2022
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
looks good in general! left a few nits
Contributor
|
spellcheck is complaining about all of the acronyms used here. Seems like we need to add them to the wordslist -- https://github.com/ethereum/execution-apis/blob/main/wordlist.txt |
mkalinin
reviewed
Jan 26, 2022
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
Great work! I left a few nits and question. Also, a general thing, IMO we should add an ## Authentication section to the main specification and reference this document. This section may contain keypoints like CLI param, port, and a short description of the approach i.e. JWT reference.
djrtwo
reviewed
Feb 7, 2022
djrtwo
approved these changes
Feb 7, 2022
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
This looks good to me. Merging in next 24 hours
10 tasks
11 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #162 .
Differences:
Todo: