This repository was archived by the owner on Feb 9, 2023. It is now read-only.
Adds description to preamble.#28
Merged
lightclient merged 8 commits intoethereum:masterfrom Aug 17, 2021
Merged
Conversation
Member
|
@lightclient can you please make a cargo release after this, so we can update the travis config on the EIPs repository? |
Member
|
@MicahZoltu should also add to the README |
Author
Good catch. Fixed. |
Member
|
You need to extend the matcher (further down): match key {
"eip" => insert!(preamble.eip, validators::eip, t),
"title" => insert!(preamble.title, validators::title, t),
"author" => insert!(preamble.author, validators::author, t), |
Author
|
Added that plus a validator that is currently a no-op. If someone has ideas for a real validation we could add it, but I don't actually speak rust so anything beyond a length check will probably require an actual expert. |
axic
reviewed
Aug 17, 2021
I'm really just guessing if this is the right way to do this.
lightclient
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm really just guessing if this is the right way to do this.