Skip to content
This repository was archived by the owner on Feb 9, 2023. It is now read-only.

Adds description to preamble.#28

Merged
lightclient merged 8 commits intoethereum:masterfrom
MicahZoltu:patch-1
Aug 17, 2021
Merged

Adds description to preamble.#28
lightclient merged 8 commits intoethereum:masterfrom
MicahZoltu:patch-1

Conversation

@MicahZoltu
Copy link

I'm really just guessing if this is the right way to do this.

@axic
Copy link
Member

axic commented Aug 17, 2021

@lightclient can you please make a cargo release after this, so we can update the travis config on the EIPs repository?

@axic
Copy link
Member

axic commented Aug 17, 2021

@MicahZoltu should also add to the README

@MicahZoltu
Copy link
Author

@MicahZoltu should also add to the README

Good catch. Fixed.

@axic
Copy link
Member

axic commented Aug 17, 2021

You need to extend the matcher (further down):

            match key {
                "eip" => insert!(preamble.eip, validators::eip, t),
                "title" => insert!(preamble.title, validators::title, t),
                "author" => insert!(preamble.author, validators::author, t),

@MicahZoltu
Copy link
Author

Added that plus a validator that is currently a no-op. If someone has ideas for a real validation we could add it, but I don't actually speak rust so anything beyond a length check will probably require an actual expert.

@lightclient lightclient merged commit 7a94eed into ethereum:master Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants