EIP7594-Polynomial-Commitments-Tests: Extend Tests for FFT and Coset FFT.#3804
Merged
asn-d6 merged 3 commits intoethereum:devfrom Jun 14, 2024
Merged
EIP7594-Polynomial-Commitments-Tests: Extend Tests for FFT and Coset FFT.#3804asn-d6 merged 3 commits intoethereum:devfrom
asn-d6 merged 3 commits intoethereum:devfrom
Conversation
asn-d6
approved these changes
Jun 14, 2024
Contributor
asn-d6
left a comment
asn-d6
left a comment
There was a problem hiding this comment.
Good test additions. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the tests for
fft_fieldandcoset_fft_fieldin EIP7594.Previously, the tests just checked that doing an inverse FFT after an FFT results in the original coefficients.
Especially, the tests would have accepted even if both FFT and inverse FFT had done nothing.
The new test additionally checks that the result of the FFT is consistent with individually evaluating the polynomial via
evaluate_polynomialcoeff.