Merged
Conversation
kevaundray
approved these changes
Jun 11, 2024
asn-d6
force-pushed
the
remove-compute-cells
branch
from
b0da34e to
93dfcda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #3788,
compute_cellshas been replaced bycompute_cells_and_kzg_proofsand as a resultcompute_cellsis no longer used. I don't believe this function is necessary now. I'm unaware of a situation where one would need the cells without proofs. Also, if you don't care about the proofs, you could usecompute_cells_and_kzg_proofsand discard the proofs.