Adds CI to generate test vectors#3793
Merged
parithosh merged 68 commits intoethereum:devfrom Jun 11, 2024
Merged
Conversation
hwwhww
approved these changes
Jun 10, 2024
Contributor
hwwhww
left a comment
hwwhww
left a comment
There was a problem hiding this comment.
THANK YOU @parithosh! 👏 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow spins up a new cloud instance and generates as well as uploads the test vectors. The workflow needs to be manually triggered and it will not run on a commit/schedule. While being triggered manually, the CI can be passed with the info as to the specs repo branch to use as an input.
The CI takes ~3h to generate the test vectors. There are potential future improvements using newer versions of python or pypi, the instance currently allocated
size-chungus-x64is mostly at idle due to lack of great parallelism. Ideally the future changes makes better utilization of the resources.P.S - Yes will squash and merge once its approved :)