Electra: Rename objects with prefix ExecutionLayerXXX#3791
Merged
hwwhww merged 4 commits intoethereum:devfrom Jun 10, 2024
Merged
Electra: Rename objects with prefix ExecutionLayerXXX#3791hwwhww merged 4 commits intoethereum:devfrom
hwwhww merged 4 commits intoethereum:devfrom
Conversation
mkalinin
approved these changes
Jun 6, 2024
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
The proposed renaming makes sense to me as having both ExecutionLayer prefix and Request suffix looks redundant from my perspective
Contributor
|
I like this clean-up! Hope to see more support (approvals/👍) before merging it. |
dapplion
approved these changes
Jun 7, 2024
hwwhww
force-pushed
the
rename-executionlayer-objs
branch
from
6e4bace to
a6341af
Compare
hwwhww
force-pushed
the
rename-executionlayer-objs
branch
from
a6341af to
99dfc9a
Compare
ensi321
approved these changes
Jun 8, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
Following #3757, which renames from DepositReceipt to DepositRequest to conform with the patterns in EIP-7685, this PR aims to have further conformity by dropping the ExecutionLayer prefix from WithdrawalRequest and ConsolidationRequest.
Changes:
ExecutionLayerWithdrawalRequest->WithdrawalRequestExecutionLayerConsolidationRequest->ConsolidationRequestprocess_execution_layer_withdrawal_request->process_withdrawal_requestprocess_execution_layer_consolidation_request->process_consolidation_requestexecution_layer_withdrawal_request->withdrawal_requestexecution_layer_consolidation_request->consolidation_request