recover_cells_and_kzg_proofs & matrix refactor#3788
Conversation
|
Code looks good! BTW, why did you "Replace ExtendedMatrix and DataColumn types with MatrixEntry container."? It seems like this was not necessary. No strong opinion, just wondering. I kinda liked |
Good question. I actually wanted to keep the types, but ran into remerkable issues. I tried doing this: - List[Cell, MAX_CELLS_IN_EXTENDED_MATRIX]
+ List[Tuple[Cell, KZGProof], MAX_CELLS_IN_EXTENDED_MATRIX]And it had this error: Spent some time trying to fix it but couldn't figure it out. |
Hmm, might be worth looking into fixing this. Right now |
hwwhww
left a comment
There was a problem hiding this comment.
I like this refactor!
- I don't have a strong feeling about making
ColumnIndexan alias ofCelIIDby inheritance (8c4a42c). Probably not worth introducing a new hardcode in the spec builder? - +1 on renaming
CellIDtoCellIndexbecause they are consecutive numbers. If so, we can leave "ID" for the nonconsecutive identifiers likeNodeID.
I don't have a strong opinion on this either. Maybe we should wait a little while and/or do it in a different PR.
Great, agreed! Unless you want me to do it here, I would like to do this in another PR. It'll be easy, just a lot of changes. |
recover_cells_and_kzg_proofs & matrix refactor


This PR does the following:
recover_all_cellstorecover_cells_and_kzg_proofs.ExtendedMatrixandDataColumntypes withMatrixEntrycontainer.cells_dictwith sequence ofMatrixEntryvalues.