chore: Refactor cell recovery code#3781
Merged
asn-d6 merged 29 commits intoethereum:devfrom Jun 11, 2024
Merged
Conversation
kevaundray
commented
May 27, 2024
kevaundray
changed the title
jtraglia
reviewed
May 28, 2024
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
I think this refactor is cleaner, thanks!
b-wagn
reviewed
Jun 7, 2024
Contributor
b-wagn
left a comment
b-wagn
left a comment
There was a problem hiding this comment.
I left some minor comments.
In general, I think this change improves the structure a lot. 👍
...pyspec/eth2spec/test/eip7594/unittests/polynomial_commitments/test_polynomial_commitments.py
Outdated
Show resolved
Hide resolved
...pyspec/eth2spec/test/eip7594/unittests/polynomial_commitments/test_polynomial_commitments.py
Show resolved
Hide resolved
...pyspec/eth2spec/test/eip7594/unittests/polynomial_commitments/test_polynomial_commitments.py
Show resolved
Hide resolved
…_of_unity` operation
… regular codepaths but not in isolated test
Co-authored-by: Justin Traglia <[email protected]>
Co-authored-by: Justin Traglia <[email protected]>
…tion_times_zero_coeffs`
kevaundray
force-pushed
the
kw/recover_all_cells_ref
branch
from
6f5985b to
1593ede
Compare
kevaundray
force-pushed
the
kw/recover_all_cells_ref
branch
from
d43c3ee to
b0be78a
Compare
asn-d6
suggested changes
Jun 10, 2024
Contributor
asn-d6
left a comment
asn-d6
left a comment
There was a problem hiding this comment.
Thanks for this PR, @kevaundray ! I agree this is a better way at looking at (and implementing) the protocol.
I added some comments about the special-case vanishing poly code added in this ticket, that I would like to be discussed before merging this.
...pyspec/eth2spec/test/eip7594/unittests/polynomial_commitments/test_polynomial_commitments.py
Show resolved
Hide resolved
jtraglia
reviewed
Jun 11, 2024
jtraglia
approved these changes
Jun 11, 2024
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making those changes 😄
This was referenced Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modularizes what was previously being called a "shift on a polynomial" to the coset_fft method.
Initially it was named "shift_fft_field" so that it is not confused with the cosets created by reverse_bit_ordering, but left it as this because this is the conventional name.
Changes made:
zero_poly_eval_brpunder sanity check comment as its only used for sanity checking