Skip to content

Provide Max Size For Columns By Range Request#3760

Merged
hwwhww merged 2 commits intoethereum:devfrom
nisdas:patch-5
May 12, 2024
Merged

Provide Max Size For Columns By Range Request#3760
hwwhww merged 2 commits intoethereum:devfrom
nisdas:patch-5

Conversation

@nisdas
Copy link
Contributor

@nisdas nisdas commented May 9, 2024

Inline with our other P2P request types, we provide a maximum size for the list of column indexes so that they can be serialized accurately.

Copy link
Contributor Author

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that setting the max size to MAX_REQUEST_DATA_COLUMN_SIDECARS , might be too large for a by range request, however in order to serialize these lists correctly we require a fixed constant. Changed it to NUMBER_OF_COLUMNS for now

@hwwhww hwwhww merged commit 5f48840 into ethereum:dev May 12, 2024
@hwwhww hwwhww added the eip7594 PeerDAS label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eip7594 PeerDAS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants