Change excess_data_gas and data_gas_used type from uint256 to uint64#3392
Merged
Change excess_data_gas and data_gas_used type from uint256 to uint64#3392
excess_data_gas and data_gas_used type from uint256 to uint64#3392Conversation
lightclient
approved these changes
May 30, 2023
mkalinin
approved these changes
May 31, 2023
djrtwo
approved these changes
May 31, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
lgtm. should make sure to test this in hive as well
(not sure the CI issues)
2 tasks
hwwhww
force-pushed
the
excess_data_gas-type
branch
from
cac23ca to
69ce4bb
Compare
Contributor
Author
|
updated: changed |
hwwhww
changed the title
ExecutionPayload.excess_data_gas type from uint256 to uint64excess_data_gas and data_gas_used type from uint256 to uint64
Merged
7 tasks
8 tasks
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a PR to track it:
@karalabe raised it on R&D Discord:
Note:
data_gas_usedfield (added by #3391) should also change touint64if this PR gets included.EIP update PR: ethereum/EIPs#7095