Conversation
terencechain
approved these changes
May 29, 2023
djrtwo
approved these changes
May 31, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
we should probably have a couple of tests with some non-zero execution payload values just to ensure encodings can be handled fine.
Maybe a test with all values in EL payload as MAX and another as all random
2 tasks
Member
|
This has been merged into the EIP! |
8 tasks
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the recent EIP-4844 update: ethereum/EIPs#7062, the CL side also has to add
data_gas_usedfield toExecutionPayload.I intentionally didn't update EIP6110 light client specs because they are expected to be deleted in #3389.
@djrtwo
In the EIP-4844 call today (ethereum/pm#782) we tend to agree to include this change to devnet-6. That means we'd better publish a new spec release this week.