Conversation
mkalinin
approved these changes
May 25, 2023
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
I am pretty much in favour of this proposal! It allows to get rid of unnecessary complexity required to define a new feature
djrtwo
approved these changes
May 31, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
I support this!
light client spces should probably be built for a particular Fork or as a particular feature itself (EIP). Otherwise, it's just a ton of typing and boilerplate work for no gain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The current test suite requires light client specs by default, even though most feature specs do not focus on light client design.
IMO unless a feature specifically pertains to light client design, these light client specs within feature specs serve little purpose.
How did I fix it
LIGHT_CLIENT_TESTING_FORKSsetting and set it from Altair to Deneb.with_light_clientdecorator for the light client testsIt will help minimize the overhead associated with adding new feature specs.