Update the endianness of the polynomial commitments to be big endian#3354
Merged
hwwhww merged 4 commits intoethereum:devfrom May 23, 2023
Merged
Update the endianness of the polynomial commitments to be big endian#3354hwwhww merged 4 commits intoethereum:devfrom
hwwhww merged 4 commits intoethereum:devfrom
Conversation
hwwhww
reviewed
May 15, 2023
Co-authored-by: Hsiao-Wei Wang <[email protected]>
g11tech
changed the title
Contributor
|
In CL, represent these as CL shouldn't have to see into these commitments, it only has to pass the opaque data to the crypto lib |
Contributor
|
KZG test vectors: general-kzg-4844-20230518.tar.gz It would be nice if we could verify the KZG update correctness before the spec release. 🙏 |
Member
Just to confirm, these test vectors work in c-kzg-4844 after making the required changes. |
asn-d6
reviewed
May 19, 2023
Contributor
|
I'm encountering errors on the consensus-specs test in go-kzg-4844 -- Going to check in a minute to see if I made a wrong change |
kevaundray
approved these changes
May 19, 2023
hwwhww
approved these changes
May 23, 2023
1 task
8 tasks
11 tasks
This was referenced Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the endianess of polynomal commitments to
bigendian in conjuction withpost ACD may 11 call discussion (Ref: https://discord.com/channels/595666850260713488/745077610685661265/1106250714415648849)