Specify the number of sidecar subnets#3346
Merged
djrtwo merged 2 commits intoethereum:devfrom May 18, 2023
Merged
Conversation
djrtwo
approved these changes
May 8, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
looks good!
I'm not immediately sure why test-eip-6110 CI failed. I just re-triggeredd the build to see if that helps
hwwhww
approved these changes
May 9, 2023
haxxpop
force-pushed
the
sidecar-subnets
branch
2 times, most recently
from
eef0b0c to
a8c3891
Compare
Member
Author
|
@hwwhww Do you have an insight on the CI error? |
Contributor
|
@ppopth I believe since EIP6110 CI job was merged to the CI |
Previously the number of subnets is equal to MAX_BLOBS_PER_BLOCK which specifies the number of blobs per block. This commit now makes the number of subnets equal to BLOB_SIDECAR_SUBNET_COUNT instead. The advantage of doing this is that we can change MAX_BLOBS_PER_BLOCK without worrying about the p2p network structure and the number of subnets.
djrtwo
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the number of subnets is equal to
MAX_BLOBS_PER_BLOCKwhich specifies the number of blobs per block. This commit now makes the number of subnets equal toBLOB_SIDECAR_SUBNET_COUNTinstead.The advantage of doing this is that we can change
MAX_BLOBS_PER_BLOCKwithout worrying about the p2p network structure and the number of subnets.