Conversation
|
I would apply the rule to use the gossip topic's fork version for BLSToExecution topics, even if it's not standard across all topics |
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
I'm okay with this but am not too worried about the UX issue if we don't patch. That said, if engineers are comfortable with this, it will ensure we don't get a bunch of dropped messages
specs/capella/p2p-interface.md
Outdated
|
|
||
| This topic is used to propagate signed bls to execution change messages to be included in future blocks. | ||
|
|
||
| Let `head_state` be a post state of the head of canonical chain. |
There was a problem hiding this comment.
Just the chain or including any empty transitions to get to the current slot wrt wall time?
There was a problem hiding this comment.
Good point, I think we don't need the whole state in the definition of this change. I'll switch to system_clock_epoch (Thought this name for the variable would be less ambiguous than current_epoch)
|
I am in favour of this approach over the partial patch in #3135. I'm also open to the full cleanup of gossip topics, but think we could add that in a future fork to avoid delaying Capella. It doesn't seem like there would be any issue in spec or impl, but the devil is in the details and it would take time from the spec side and every team to roll it out. |
Co-authored-by: Michael Sproul <[email protected]>
|
Per the fork version validation, another solution is making |
|
Closing in favour of #3206 |
5 participants
A stopgap fix for BLSToExecution gossip validation:
This fix only make sense if we can't afford a general fix of gossip messages validation because of additional engineering complexity. The general fix would be to always use a fork version from a gossip topic to compute signing domain across all topics.