Clarify BeaconBlockAndBlobsSidecarByRoot no blob available#3154
Merged
djrtwo merged 3 commits intoethereum:devfrom Dec 21, 2022
Merged
Clarify BeaconBlockAndBlobsSidecarByRoot no blob available#3154djrtwo merged 3 commits intoethereum:devfrom
djrtwo merged 3 commits intoethereum:devfrom
Conversation
Member
Author
|
@djrtwo thanks for the feedback, applied comments. Should there be a sentence noting the consequences of that line if
|
Contributor
|
@dapplion Is that because you don't think the |
Member
Author
|
Wording is clear to us, but the consequences as discussed today are important. So I feel that (for new readers for example) calling out that nuance is a useful pointer |
ghost
approved these changes
Dec 19, 2022
ghost
approved these changes
Dec 19, 2022
Contributor
|
merging! feel free to add an additional comment in another PR |
|
😱...estoy atónito!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peers may not know the slot of a block when requesting by root. So they may request a root via BeaconBlockAndBlobsSidecarByRoot which does not have any associated blob.
This situation only applies before finalizing EIP4844_FORK_EPOCH. From discussions in #3139 a simple solution that requires a retry is the best trade-off to minimize complexity.
I picked the error code
3: ResourceUnavailablewithout strong reasoning. Happy to change to another more meaningful one.