Add new DomainType for application usage.#2882
Closed
ralexstokes wants to merge 1 commit intoethereum:devfrom
Closed
Add new DomainType for application usage.#2882ralexstokes wants to merge 1 commit intoethereum:devfrom
DomainType for application usage.#2882ralexstokes wants to merge 1 commit intoethereum:devfrom
Conversation
Member
Author
34 tasks
Contributor
|
I'm okay with either this or setting a high bit to give applications a large space to avoid any accidental signing. |
Member
Author
|
closing in lieu of #2884. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
DomainTypefor use by applications adjacent to the core protocol so they can leverage the signing machinery developed here when working with consensus types.This PR only adds a single domain and expects applications using the domain type to mix in further unique tags for domain separation; otherwise they risk signature collisions.
An example use case is the work-in-progress Builder API where a validator may want to outsource block construction to a network of builders external to their local execution client. See ethereum/execution-apis#209 for details.