Merged
Conversation
djrtwo
approved these changes
Nov 24, 2021
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
Looks good.
Note to readers that TERMINAL_TOTAL_DIFFUCLTY, TERMINAL_BLOCK_HASH, and TERMINAL_BLOCK_HASH_ACTIVATION_EPOCH are still defined but must be overridden in updated configs in releases rather than on the command line
Contributor
|
leaving this up for 24 hours before merging in case other comments |
MicahZoltu
approved these changes
Nov 25, 2021
MicahZoltu
left a comment
MicahZoltu
left a comment
There was a problem hiding this comment.
From a specification standpoint, I don't think this should be specified so I think removal of this is a good thing. From a recommendation standpoint for the various client I think there is notable value in providing a CLI override flag to their users, especially enterprise users that may have a fairly onerous upgrade process but a fairly simple configuration process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing client software with updated parameters and giving a time for users to upgrade their nodes is going to be default strategy to accelerate the Merge in the case of emergency, see the comment here for details.
Therefore, CLI args doesn't increase the speed of the reaction in emergency cases hence supporting them is anymore not a requisite for a client software. This PR proposes to remove the corresponding document from the set of consensus spec docs.
cc @MicahZoltu @karalabe