re-enable dropped ssz test generators#2740
Merged
ralexstokes merged 1 commit intoethereum:devfrom Nov 30, 2021
asanso:patch-4
Merged
re-enable dropped ssz test generators#2740ralexstokes merged 1 commit intoethereum:devfrom asanso:patch-4
ralexstokes merged 1 commit intoethereum:devfrom
asanso:patch-4
Conversation
ralexstokes
approved these changes
Nov 24, 2021
Member
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
nice work! it seems that these tests were unintentionally dropped the last time this generator was written.
i ran this generator on dev and against this pr:
devcompleted generation of ssz_generic with 1905 tests (42 skipped tests) in 25.14 seconds
this-prcompleted generation of ssz_generic with 1947 tests (0 skipped tests) in 25.71 seconds
where this PR avoids the collision to produce the 42 "skipped" tests.
i'll approve now and run against another ssz implementation to verify before merging.
hwwhww
approved these changes
Nov 30, 2021
Member
|
i ran the new tests against my ssz implementation and they all seem to pass (and not cause any issues). bc of the way randomness works in the test generator, it does modify two existing tests and removes the handful of previous "collapsed" tests but i don't see an immediate issue with this. i'll go ahead and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some test were skipped to the missing mode part:
{mode.to_name()}