Skip to content

is_merge -> is_merge_transition#2738

Merged
djrtwo merged 1 commit intodevfrom
fix-names
Nov 23, 2021
Merged

is_merge -> is_merge_transition#2738
djrtwo merged 1 commit intodevfrom
fix-names

Conversation

@djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Nov 23, 2021

in eip 3675, the first PoS block is called the TRANSITION_BLOCK. We called it the merge_block here.

I agree that transition is a bit vague for the specs as it could easily collide with a name in a subsequent upgrade, so I suggest making it explicit in these names -- merge_transition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant