Merged
Conversation
mkalinin
approved these changes
Nov 16, 2021
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
It seems to be a leftover from the times when the TTD was computed during the fork on the beacon chain. We may remove it now 👍
Contributor
|
Nice. I'll go fix the CI. |
hwwhww
approved these changes
Nov 18, 2021
24 tasks
djrtwo
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
difficultyfield is unused in the specification and appears to be always set to0in fork choice tests.