Genesis execution block handling#2719
Merged
djrtwo merged 2 commits intoethereum:devfrom Nov 11, 2021
Merged
Conversation
mkalinin
approved these changes
Nov 11, 2021
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
The fix looks good to me! Allowing for genesis to reach TTD is better than not to
djrtwo
reviewed
Nov 11, 2021
djrtwo
approved these changes
Nov 11, 2021
4 tasks
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
get_pow_block_at_terminal_total_difficultywill raise an exception on any chain (e.g., mainnet) if thepow_chaincontains only the genesis block (e.g., unsynced node). This is becausegenesis_block.parent_hash == Hash32()andHash32()is not inpow_chain.This change also makes allowances for networks where the
TERMINAL_TOTAL_DIFFICULTYis reached at the genesis block.There's an alternative version of this fix which does not allow for a network where TTD is met at genesis: f6ed352.