Eth1 block hashes have type Hash32#2689
Closed
benjaminion wants to merge 0 commit intoethereum:devfrom
Closed
Conversation
djrtwo
approved these changes
Oct 21, 2021
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
I concur!
I do agree it worthwhile to do an exploratory typing investigation on changing hash return type itself.
Does make me wonder... should typing distinguish between keccak and sha256 hashes...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pernickety and largely of historical value now, but since we have added a custom
Hash32type for Eth1 block hashes it ought to be used in the definition ofinitialize_beacon_state_from_eth1().Related question: why are we not migrating all the other hashes over to the
Hash32type, only the Eth1 block hash? For example hereHistorical note:
Hash32used to be a thing back at the dawn of time, before being superseded by the genericBytes32.